Don't crawl actions again after being redirected to them#2557
Merged
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom Jul 12, 2025
Merged
Don't crawl actions again after being redirected to them#2557labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
labkey-tchad merged 1 commit intorelease25.7-SNAPSHOTfrom
Conversation
`.lastFilter` parameter can apply injection parameters when the crawler doesn't expect them
labkey-danield
approved these changes
Jul 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
.lastFilterparameter can apply injection parameters when the crawler doesn't expect them.The crawler would navigate to
mothership-begin.view, which redirects tomothership-showExceptions.view. Then it would throw a bunch of injection parameters atmothership-showExceptions.view. The injection checker expects to hit some non-fatal errors, and knows how to evaluate them.Later, it would crawl
mothership-showExceptions.view?.lastFilter=truewhich would apply the bad parameters to the view. The non-injection phase of the crawler is more strict about what sort of product behavior it expects and might error out when it hits something the injector was fine with.Related Pull Requests
Changes